New security Regulatory compliance API by himarkov · Pull Request #5183 · Azure/azure-rest-api-specs

himarkov · 2019-02-10T16:55:34Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

msftclas · 2019-02-10T16:55:45Z

All CLA requirements met.

AutorestCI · 2019-02-10T16:56:04Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-02-10T16:56:15Z

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#3782

AutorestCI · 2019-02-10T16:56:33Z

Automation for azure-sdk-for-js

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-js#1765

AutorestCI · 2019-02-10T16:56:42Z

Automation for azure-sdk-for-java

Nothing to generate for azure-sdk-for-java

AutorestCI · 2019-02-10T16:57:48Z

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#4374

AutorestCI · 2019-02-10T16:59:21Z

Automation for azure-sdk-for-node

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-node#5044

azuresdkci · 2019-02-10T17:10:57Z

Can one of the admins verify this patch?

jhendrixMSFT

A lot of the descriptions for the new operation IDs look to be copy/pasted. Please consider updating all of the descriptions with accurate content as they are used in doc generation.

jhendrixMSFT

Your additions are malformed JSON which is causing the failure here.

specification/security/resource-manager/Microsoft.Security/stable/2019-01-01/security.json

himarkov · 2019-02-14T08:45:41Z

@jhendrixMSFT requested changes were handled.
Thanks.

ravbhatnagar

few comments below

.../2019-01-01/examples/RegulatoryCompliance/getRegulatoryComplianceAssessmentList_example.json

specification/security/resource-manager/Microsoft.Security/stable/2019-01-01/security.json

ravbhatnagar · 2019-02-20T01:31:19Z

Looks good, except that just add the description for the filter. Signing off from ARM side.

jhendrixMSFT

Please also fix the formatting of your additions as some of the whitespacing is incorrect.
In addition, I think your List APIs should have the x-ms-pageable attribute.

specification/security/resource-manager/Microsoft.Security/stable/2019-01-01/security.json

jhendrixMSFT · 2019-02-28T19:22:01Z

@himarkov can you please resolve the merge conflict?

jhendrixMSFT · 2019-03-18T15:46:18Z

@himarkov hello any update?

himarkov · 2019-03-20T07:59:57Z

@jhendrixMSFT Hi, Sorry for my delay!
We're indeed waiting for the feature to be deployed and for everything to be ready in Prod before merging,.
Regarding the readme.md, i've now updated it as well.
Thank you!

…pecs

REST Spec PR 'Azure/azure-rest-api-specs#5183' REST Spec PR Author 'himarkov' REST Spec PR Last commit

himarkov · 2019-03-25T11:14:24Z

@jhendrixMSFT Hi,
We are ready for merge now :)
Thanks!

azuresdkci assigned jhendrixMSFT Feb 10, 2019

azuresdkci requested a review from jhendrixMSFT February 10, 2019 16:57

chlahav self-requested a review February 10, 2019 17:08

chlahav added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 10, 2019

jhendrixMSFT reviewed Feb 11, 2019

View reviewed changes

jhendrixMSFT requested changes Feb 11, 2019

View reviewed changes

nschonni reviewed Feb 12, 2019

View reviewed changes

jhendrixMSFT requested a review from ravbhatnagar February 14, 2019 15:45

ravbhatnagar reviewed Feb 19, 2019

View reviewed changes

ravbhatnagar added the ARMChangesRequested label Feb 19, 2019

AutorestCI mentioned this pull request Feb 19, 2019

[AutoPR security/resource-manager] New security Regulatory compliance API Azure/azure-sdk-for-js#1270

Closed

ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 20, 2019

chlahav added the DoNotMerge <valid label in PR review process> use to hold merge after approval label Feb 20, 2019

jhendrixMSFT requested changes Feb 20, 2019

View reviewed changes

AutorestCI mentioned this pull request Feb 24, 2019

[AutoPR security/resource-manager] New security Regulatory compliance API Azure/azure-sdk-for-node#4738

Closed

himarkov requested review from MikhailTryakhov and naveedaz as code owners March 7, 2019 15:35

himarkov added 2 commits March 20, 2019 10:11

Regulatory compliance API readme update

f944986

Merge branch 'master' of https://github.com/himarkov/azure-rest-api-s…

f2f06c6

…pecs

This was referenced Mar 20, 2019

[AutoPR security/resource-manager] New security Regulatory compliance API Azure/azure-sdk-for-js#1662

Closed

[AutoPR security/resource-manager] New security Regulatory compliance API Azure/azure-sdk-for-node#4982

Closed

himarkov and others added 9 commits March 20, 2019 10:24

Regulatory compliance API readme update

4cbcdfc

Merge branch 'master' into master

56a7ae5

Update readme.md

380e97b

Update readme.md

cc77f9f

Update readme.md

8265205

Delete security.json

c995c15

Update regulatoryCompliance.json

cbfcf95

Update regulatoryCompliance.json

1f8f6bc

Update regulatoryCompliance.json

57997a3

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 20, 2019

.NET SDK Resource Provider:'SecurityCenter'

320d167

REST Spec PR 'Azure/azure-rest-api-specs#5183' REST Spec PR Author 'himarkov' REST Spec PR Last commit

AutorestCI mentioned this pull request Mar 20, 2019

[AutoPR security/resource-manager] New security Regulatory compliance API Azure/azure-sdk-for-go#4337

Merged

adxsdknet added a commit to adxsdknet/azure-sdk-for-net that referenced this pull request Mar 20, 2019

.NET SDK Resource Provider:'SecurityCenter'

735b073

REST Spec PR 'Azure/azure-rest-api-specs#5183' REST Spec PR Author 'himarkov' REST Spec PR Last commit

Azure deleted a comment from adxsdknet Mar 20, 2019

chlahav removed the DoNotMerge <valid label in PR review process> use to hold merge after approval label Mar 24, 2019

jhendrixMSFT approved these changes Mar 25, 2019

View reviewed changes

jhendrixMSFT merged commit e6dd183 into Azure:master Mar 25, 2019

This was referenced Mar 25, 2019

[AutoPR security/resource-manager] New security Regulatory compliance API Azure/azure-sdk-for-js#1764

Merged

[AutoPR security/resource-manager] New security Regulatory compliance API Azure/azure-sdk-for-node#5043

Merged

Conversation

himarkov commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

msftclas commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AutorestCI commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

AutorestCI commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Feb 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

azuresdkci commented Feb 10, 2019

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

himarkov commented Feb 14, 2019

Uh oh!

ravbhatnagar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ravbhatnagar commented Feb 20, 2019

Uh oh!

jhendrixMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jhendrixMSFT commented Feb 28, 2019

Uh oh!

jhendrixMSFT commented Mar 18, 2019

Uh oh!

himarkov commented Mar 20, 2019

Uh oh!

himarkov commented Mar 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

himarkov commented Feb 10, 2019 •

edited

Loading

msftclas commented Feb 10, 2019 •

edited

Loading

AutorestCI commented Feb 10, 2019 •

edited

Loading

AutorestCI commented Feb 10, 2019 •

edited

Loading

AutorestCI commented Feb 10, 2019 •

edited

Loading

AutorestCI commented Feb 10, 2019 •

edited

Loading

AutorestCI commented Feb 10, 2019 •

edited

Loading

AutorestCI commented Feb 10, 2019 •

edited

Loading